Wireshark-commits: [Wireshark-commits] master-2.0 4f08ff5: Revert "Remove the deprecated column typ
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 1 Feb 2016 09:32:58 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4f08ff50d4b396adacbad33708bb487287f83c3f
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

4f08ff5 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    Revert "Remove the deprecated column types so users don't think they still exist."
    
    This reverts commit 84a85186c6637544d5fbea738e73601aa2427e11.
    You can't change the columns enum in a stable release without breaking backward compatibility with existing plugins.
    Keep the updated README.dissector as the changes are valid.
    
    Change-Id: Ie1ac8e4c07f59e72304cd4f73119a36f3e86b3cf
    Reviewed-on: https://code.wireshark.org/review/13634
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  84a8518   Remove the deprecated column types so users don't think they still exist.
    adds  4f08ff5   Revert "Remove the deprecated column types so users don't think they still exist."


Summary of changes:
 epan/column-utils.c |    3 +-
 epan/column-utils.h |  110 ++++++++++++----------
 epan/column.c       |  260 ++++++++++++++++++++++++++++++---------------------
 epan/prefs.c        |   66 +++++--------
 4 files changed, 240 insertions(+), 199 deletions(-)