Wireshark-commits: [Wireshark-commits] master c9d148c: Update filter bookmark icons.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 30 Jan 2016 22:02:54 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c9d148c077213c256e275574420fc67d61f6835a
Submitter: Stig Bjørlykke (stig@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c9d148c by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Update filter bookmark icons.
    
    Separate the capture and display filter bookmark icons. Make the capture
    icon green to match(-ish) the active capture icon. Tested on nice+new
    and janky+old displays.
    
    Change-Id: I6ed532c8a49da50fe2a7de3d8fbd0b1af7623b4a
    Reviewed-on: https://code.wireshark.org/review/13612
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    

Actions performed:

    from  22e5cdb   No need for a routine to return a GSList of extensions for compressed files.
    adds  c9d148c   Update filter bookmark icons.


Summary of changes:
 Makefile.am                                        |   27 +++++---
 image/toolbar.qrc                                  |   18 ++++--
 .../14x14/x-capture-filter-bookmark.active.png     |  Bin 0 -> 252 bytes
 ...ed.svg => x-capture-filter-bookmark.active.svg} |   62 +++++++++++++++---
 .../14x14/x-capture-filter-bookmark.active@xxxxxx  |  Bin 0 -> 413 bytes
 image/toolbar/14x14/x-capture-filter-bookmark.png  |  Bin 0 -> 269 bytes
 .../14x14/x-capture-filter-bookmark.selected.png   |  Bin 0 -> 248 bytes
 ....svg => x-capture-filter-bookmark.selected.svg} |   62 +++++++++++++++---
 .../x-capture-filter-bookmark.selected@xxxxxx      |  Bin 0 -> 425 bytes
 ...-bookmark.svg => x-capture-filter-bookmark.svg} |   66 ++++++++++++++++----
 .../toolbar/14x14/x-capture-filter-bookmark@xxxxxx |  Bin 0 -> 405 bytes
 ...ve.png => x-display-filter-bookmark.active.png} |  Bin 254 -> 254 bytes
 ...ve.svg => x-display-filter-bookmark.active.svg} |    0
 ...png => x-display-filter-bookmark.active@xxxxxx} |  Bin 403 -> 403 bytes
 ...-bookmark.png => x-display-filter-bookmark.png} |  Bin 238 -> 238 bytes
 ....png => x-display-filter-bookmark.selected.png} |  Bin 258 -> 258 bytes
 ....svg => x-display-filter-bookmark.selected.svg} |    0
 ...g => x-display-filter-bookmark.selected@xxxxxx} |  Bin 400 -> 400 bytes
 ...-bookmark.svg => x-display-filter-bookmark.svg} |   52 +++++++++++++--
 ...ark@xxxxxx => x-display-filter-bookmark@xxxxxx} |  Bin 392 -> 392 bytes
 image/toolbar/svg-to-png.sh                        |    9 ++-
 ui/qt/capture_filter_edit.cpp                      |    4 +-
 ui/qt/display_filter_edit.cpp                      |    4 +-
 23 files changed, 249 insertions(+), 55 deletions(-)
 create mode 100644 image/toolbar/14x14/x-capture-filter-bookmark.active.png
 copy image/toolbar/14x14/{x-filter-bookmark.selected.svg => x-capture-filter-bookmark.active.svg} (57%)
 create mode 100644 image/toolbar/14x14/x-capture-filter-bookmark.active@xxxxxx
 create mode 100644 image/toolbar/14x14/x-capture-filter-bookmark.png
 create mode 100644 image/toolbar/14x14/x-capture-filter-bookmark.selected.png
 copy image/toolbar/14x14/{x-filter-bookmark.selected.svg => x-capture-filter-bookmark.selected.svg} (57%)
 create mode 100644 image/toolbar/14x14/x-capture-filter-bookmark.selected@xxxxxx
 copy image/toolbar/14x14/{x-filter-bookmark.svg => x-capture-filter-bookmark.svg} (58%)
 create mode 100644 image/toolbar/14x14/x-capture-filter-bookmark@xxxxxx
 rename image/toolbar/14x14/{x-filter-bookmark.active.png => x-display-filter-bookmark.active.png} (100%)
 rename image/toolbar/14x14/{x-filter-bookmark.active.svg => x-display-filter-bookmark.active.svg} (100%)
 rename image/toolbar/14x14/{x-filter-bookmark.active@xxxxxx => x-display-filter-bookmark.active@xxxxxx} (100%)
 rename image/toolbar/14x14/{x-filter-bookmark.png => x-display-filter-bookmark.png} (100%)
 rename image/toolbar/14x14/{x-filter-bookmark.selected.png => x-display-filter-bookmark.selected.png} (100%)
 rename image/toolbar/14x14/{x-filter-bookmark.selected.svg => x-display-filter-bookmark.selected.svg} (100%)
 rename image/toolbar/14x14/{x-filter-bookmark.selected@xxxxxx => x-display-filter-bookmark.selected@xxxxxx} (100%)
 rename image/toolbar/14x14/{x-filter-bookmark.svg => x-display-filter-bookmark.svg} (63%)
 rename image/toolbar/14x14/{x-filter-bookmark@xxxxxx => x-display-filter-bookmark@xxxxxx} (100%)