Wireshark-commits: [Wireshark-commits] master 841f636: Add Authentication Header (AU) support for M
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 27 Jan 2016 15:39:25 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=841f636dc075a306cd048e7f954b8cba5fa6960c
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

841f636 by Tomofumi Hayashi (s1061123@xxxxxxxxx):

    Add Authentication Header (AU) support for MEGACO packet.
    
    RFC3015 indicates that megaco packet may have AuthenticationHeader, 'AU', as
     + appendix A.2 ASN.1 syntax specification, and
     + appendix B.2 ABNF specification.
    
    Currently wireshark does not decode MEGACO packet with AU because
    wireshark just gives up to decode at AU field, although the data
    following AU field is possible to decode.
    
    This fix inspects the MEGACO packet for AuthenticationHeader and skip it
    if it exists. In further enhancement, it will be shown as appropreate format.
    
    Bug: 12051
    Change-Id: Ibcea8554a4079a687584b84164b2a4d177dca7f4
    Reviewed-on: https://code.wireshark.org/review/13559
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  ef75268   Allow/Create an option to use "capture filter" labels defined in wireshark GUI from CLI
    adds  841f636   Add Authentication Header (AU) support for MEGACO packet.


Summary of changes:
 epan/dissectors/packet-megaco.c |   22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)