Wireshark-commits: [Wireshark-commits] master f96c561: ssl: enable "decryption" without keys for NU
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 27 Jan 2016 09:19:47 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f96c56103b12302b2b235382627f8c035a890bdf
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

f96c561 by Peter Wu (peter@xxxxxxxxxxxxx):

    ssl: enable "decryption" without keys for NULL ciphers
    
    NULL ciphers have their content in plaintext which can be dissected.
    When the keys are available, decryption and MAC validation works as
    usual. When the master secret cannot be found, continue anyway in case
    of NULL ciphers.
    
    Change-Id: I1ba6de6333fad58cabc757544490cddca7d82e26
    Ping-Bug: 4652
    Reviewed-on: https://code.wireshark.org/review/13536
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  850f5d3   Remove the deprecated column types so users don't think they still exist.
    adds  f96c561   ssl: enable "decryption" without keys for NULL ciphers


Summary of changes:
 epan/dissectors/packet-ssl-utils.c |   48 +++++++++++++++++++++++++++++-------
 1 file changed, 39 insertions(+), 9 deletions(-)