Wireshark-commits: [Wireshark-commits] master a7c025f: Fix missing validation (crash) for certain p
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 25 Jan 2016 18:16:24 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a7c025fd142a291f1cb9e405a2a6e24a842be058
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a7c025f by Peter Wu (peter@xxxxxxxxxxxxx):

    Fix missing validation (crash) for certain prefs
    
    The gui.layout_type preference is part of the Layout submodule (which is
    part of the gui module. The Layout submodule has a special apply
    callback that validates its prefs. These validations were never called
    though because the prefix is "gui" and as a result that module would be
    marked as changed.
    
    Fix this crash by calling the validation function on the submodules
    instead holding the pref, not its parent.
    
    Change-Id: I2a49dce93fdc7fab4ab3dc52dad90288c2d17434
    Reviewed-on: https://code.wireshark.org/review/13154
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  b2bd03c   [skinny] pinfo->fd-num changed to pinfo->num
    adds  a7c025f   Fix missing validation (crash) for certain prefs


Summary of changes:
 epan/prefs.c |   44 +++++++++++++++++++++++++++++++++-----------
 1 file changed, 33 insertions(+), 11 deletions(-)