Wireshark-commits: [Wireshark-commits] master-2.0 cf4d53c: Qt: Fix checkSaveAsWithComments() button
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 25 Jan 2016 11:38:32 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cf4d53c3498a3c19cf27283e6b8d5595b71bfd9f
Submitter: Stig Bjørlykke (stig@xxxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

cf4d53c by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    Qt: Fix checkSaveAsWithComments() button check
    
    When using QMessageBox with custom buttons, exec() function returns
    an opaque value.  Therefore we should use clickedButton() to determine
    which button was clicked.
    
    Example in https://wiki.qt.io/Custom_QMessageBox_Buttons
    
    Change-Id: I81824414e31345bb9ea77f72f1b4cdeaa21d2781
    Reviewed-on: https://code.wireshark.org/review/13523
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    (cherry picked from commit cb0f530cae99e92131a4f3ff2ad8a74475edc87f)
    Reviewed-on: https://code.wireshark.org/review/13526
    

Actions performed:

    from  237bbc4   [Automatic update for 2016-01-24]
    adds  cf4d53c   Qt: Fix checkSaveAsWithComments() button check


Summary of changes:
 ui/qt/capture_file_dialog.cpp |   51 ++++++++++++++++++++---------------------
 1 file changed, 25 insertions(+), 26 deletions(-)