Wireshark-commits: [Wireshark-commits] master 9eda2fa: Set width of hex output according to bitmask
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 24 Jan 2016 00:03:30 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9eda2fa063569c49ce238d6bbee023c91b46d879
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

9eda2fa by Kevin Bracey (kevin.bracey@xxxxxxx):

    Set width of hex output according to bitmask
    
    Output from BASE_HEX et al has always been zero-padded to according to
    the field type - 8 digits for FT_UINT32, etc.
    
    When the field has a bitmask, this is definitely not appropriate - the
    field type is used to indicate the size of the bitfield container, and
    tells us nothing about the size of this field.
    
    Instead, determine the actual size of the field by inspecting the
    bitmask, and output the corresponding number of hex digits.
    
    Change-Id: I10ec4e93e1e40e8b1354d5368cc8945cf671a617
    Reviewed-on: https://code.wireshark.org/review/13225
    Reviewed-by: João Valverde <j@xxxxxx>
    Petri-Dish: João Valverde <j@xxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  88cd655   Qt: Load qt_XX.qm to translate Qt Strings
    adds  9eda2fa   Set width of hex output according to bitmask


Summary of changes:
 epan/dissectors/packet-ipv6.c |    6 +--
 epan/proto.c                  |  118 ++++++++++++++++++++---------------------
 epan/proto.h                  |    6 ---
 wsutil/bits_ctz.h             |   47 +++++++++++++++-
 4 files changed, 106 insertions(+), 71 deletions(-)