Wireshark-commits: [Wireshark-commits] master-2.0 0551667: Fix handling of the magic number.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 23 Jan 2016 01:09:33 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0551667b1938759ba194179557f25cf2ec8f23b1
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

0551667 by Guy Harris (guy@xxxxxxxxxxxx):

    Fix handling of the magic number.
    
    Just treat it as an array of bytes.  When checking for whether it's a
    pcap file, also determine whether it's big-endian or little-endian.
    Note that reading it in *host* byte order will tell you whether it's in
    your byte order or byte-swapped; you have to know your byte order to
    know whether that means little-endian or big-endian.
    
    Have a #define for the magic number size, as all magic number values
    must be that size, and use that as the size of the magic-number arrays.
    
    Handle nanosecond timestamp resolution while we're at it.
    
    Change-Id: Ia11b8be18892f2cc056c88fcdefe461dfd16818a
    Reviewed-on: https://code.wireshark.org/review/13492
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  b36dbfb   GSM A DTAP: fix display of calling/called party BCD number in parent tree
    adds  0551667   Fix handling of the magic number.


Summary of changes:
 epan/dissectors/file-pcap.c |   67 ++++++++++++++++++++++++++++---------------
 1 file changed, 44 insertions(+), 23 deletions(-)