Wireshark-commits: [Wireshark-commits] master fc511c3: CIP: Add support for Get Attributes All
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 22 Jan 2016 12:37:33 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fc511c3f11d1e744adbf8fff6b1e46adc9776c94
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

fc511c3 by Michael Mann (mmann78@xxxxxxxxxxxx):

    CIP: Add support for Get Attributes All
    
    Get Attributes All is a predefined list of existing attribute IDs for a given class.  Add a new index for each attribute for their place in GetAttributesAll response. Then a hash table of classes for existing attributes are created to handle the GetAttributesAll service.
    
    Added more TCP/IP object attributes since more have been added to the spec.
    Moved TCP/IP object attributes all to ENIP dissector.
    
    Bug: 11996
    Change-Id: I7f50c9aadf04efdb17ef31f39e6a991c0a84bef2
    Reviewed-on: https://code.wireshark.org/review/13186
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  db111c4   ISAKMP: Optimize loops
    adds  fc511c3   CIP: Add support for Get Attributes All


Summary of changes:
 epan/dissectors/packet-cip.c       |  331 +++++++++++++++++++++++++++---------
 epan/dissectors/packet-cip.h       |   35 +++-
 epan/dissectors/packet-cipsafety.c |  139 ++++++---------
 epan/dissectors/packet-cipsafety.h |    2 +-
 epan/dissectors/packet-enip.c      |  187 ++++++++++++++------
 epan/dissectors/packet-enip.h      |    2 +-
 6 files changed, 473 insertions(+), 223 deletions(-)