Wireshark-commits: [Wireshark-commits] master-2.0 c98c845: Qt: fix a crash when trying to open TCP
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 21 Jan 2016 07:54:35 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c98c845dae557dffcc67476be49e075951438d66
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

c98c845 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    Qt: fix a crash when trying to open TCP stream graph on a truncated TCP packet
    
    Do not try to show TCP stream graph window if it was rejected in constructor
    
    Change-Id: I4d1401e2c356391ceb8c8e3d37a668fc2a9fc92f
    Reviewed-on: https://code.wireshark.org/review/13454
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 06b75181a0a7033e270eae0b8009f5628048f0b5)
    Reviewed-on: https://code.wireshark.org/review/13465
    

Actions performed:

    from  1a8ba46   Qt: ensure to call destructor when closing a few QDialog windows
    adds  c98c845   Qt: fix a crash when trying to open TCP stream graph on a truncated TCP packet


Summary of changes:
 ui/qt/main_window_slots.cpp |    4 +++-
 ui/qt/tcp_stream_dialog.cpp |    1 +
 ui/tap-tcp-stream.c         |    2 +-
 3 files changed, 5 insertions(+), 2 deletions(-)