Wireshark-commits: [Wireshark-commits] master c9db8c5: mrdisc: don't THROW() an exception from a di
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 21 Jan 2016 03:09:03 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c9db8c5a67b8d0c81fd27e4bf05ad786d1a3f269
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c9db8c5 by Martin Kaiser (wireshark@xxxxxxxxx):

    mrdisc: don't THROW() an exception from a dissector
    
    in this case, we can just continue dissecting
    proto_tree_add_item() will throw the exception for us if we
    don't have enough data
    
    Change-Id: I8c0bfa8eaff9119ae00e69601bf5f37501574044
    Reviewed-on: https://code.wireshark.org/review/13462
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  14c68a3   Fix warning for funnel.c [-Wcast-qual]
    adds  c9db8c5   mrdisc: don't THROW() an exception from a dissector


Summary of changes:
 epan/dissectors/packet-mrdisc.c |    6 ------
 1 file changed, 6 deletions(-)