Wireshark-commits: [Wireshark-commits] master 06b7518: Qt: fix a crash when trying to open TCP stre
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 20 Jan 2016 23:39:26 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=06b75181a0a7033e270eae0b8009f5628048f0b5
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

06b7518 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    Qt: fix a crash when trying to open TCP stream graph on a truncated TCP packet
    
    Do not try to show TCP stream graph window if it was rejected in constructor
    
    Change-Id: I4d1401e2c356391ceb8c8e3d37a668fc2a9fc92f
    Reviewed-on: https://code.wireshark.org/review/13454
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  4b35048   Qt: ensure to call destructor when closing a few QDialog windows
    adds  06b7518   Qt: fix a crash when trying to open TCP stream graph on a truncated TCP packet


Summary of changes:
 ui/qt/main_window_slots.cpp |    4 +++-
 ui/qt/tcp_stream_dialog.cpp |    1 +
 ui/tap-tcp-stream.c         |    2 +-
 3 files changed, 5 insertions(+), 2 deletions(-)