Wireshark-commits: [Wireshark-commits] master 5335f1d: DCM: ignore the upper flag bits of PDV in PD
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 19 Jan 2016 09:57:40 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5335f1d065b1e30619ed7c2ba4a68b9df48ad157
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5335f1d by Rich Coe (richcoe2@xxxxxxxxx):

        DCM: ignore the upper flag bits of PDV in PDU DATA packet
    
        The DICOM protocol in PS3.8 E.2 says bits 2-7 should be set to zero by the
        sender and not checked by the receiver.  The version of software sending a
        bad PDV flags is PACSONE01AUG03.  The version of this software might be
        2004-02-07 (or earlier) found at http://www.pacsone.net/download.htm
    
    Change-Id: If4d9d8e63d7bdba0f8f1c50e49979ca15b5f9157
    Reviewed-on: https://code.wireshark.org/review/13384
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  174fa7e   MAUSB: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang
    adds  5335f1d       DCM: ignore the upper flag bits of PDV in PDU DATA packet


Summary of changes:
 epan/dissectors/packet-dcm.c |   32 +++++++++++++++++++++++---------
 1 file changed, 23 insertions(+), 9 deletions(-)