Wireshark · Wireshark-commits: [Wireshark-commits] master 6d0bc20: Qt: Fixup the Display Filter Expression syntax logic.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6d0bc20d4e4853deb7da13312fb3eb3e36b4160f
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

6d0bc20 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Fixup the Display Filter Expression syntax logic.
    
    In the Display Filter Expression dialog, only disable the OK button when
    we have an invalid filter.
    
    Move the deprecated warning string from DisplayFilterEdit::checkFilter
    to SyntaxLineEdit::checkDisplayFilter so that we can use it in more
    places.
    
    Change-Id: I938f5f10258f4fd9dd3a33c174dd9958c9634766
    Reviewed-on: https://code.wireshark.org/review/13317
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  7b2afd5   androiddump: There is no need to make full copy optarg
    adds  6d0bc20   Qt: Fixup the Display Filter Expression syntax logic.


Summary of changes:
 ui/qt/display_filter_edit.cpp              |    8 +-------
 ui/qt/display_filter_expression_dialog.cpp |    2 +-
 ui/qt/syntax_line_edit.cpp                 |   13 ++++++-------
 ui/qt/syntax_line_edit.h                   |    1 -
 4 files changed, 8 insertions(+), 16 deletions(-)