Wireshark-commits: [Wireshark-commits] master 5625dc7: Correctly construct subset tvbuffs.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 17 Jan 2016 08:30:14 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5625dc78dbe685a4a60a2c95b73034b5722f2dd1
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5625dc7 by Guy Harris (guy@xxxxxxxxxxxx):

    Correctly construct subset tvbuffs.
    
    Use tvb_subset_remaining() or tvb_subset_length() - they calculate the
    correct captured length for you.  This fixes, for example, the EoIB
    code, where you ended up with tvbuffs with captured length > reported
    length.
    
    Change-Id: Ie792b53a796d4b32242cb83020b54232a2a09698
    Reviewed-on: https://code.wireshark.org/review/13355
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  86ade27   Dissect Ethernet-over-GFP frames with the "with the FCS" dissector.
    adds  5625dc7   Correctly construct subset tvbuffs.


Summary of changes:
 epan/dissectors/packet-infiniband.c |   31 ++++++++-----------------------
 1 file changed, 8 insertions(+), 23 deletions(-)