Wireshark-commits: [Wireshark-commits] master-1.12 f68b92b: Use the "no FCS" version of the Etherne
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 17 Jan 2016 02:58:27 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f68b92b9f0b2a2747adecf3fef60e4f63e418ea2
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

f68b92b by Guy Harris (guy@xxxxxxxxxxxx):

    Use the "no FCS" version of the Ethernet dissector.
    
    RFC 6325, section 4.1.4 "Frame Check Sequence (FCS)", says
    
    	"Thus, when a frame is encapsulated, the original FCS is not
    	included but is discarded."
    
    meaning that the inner Ethernet frame does *not* include an FCS.
    
    Change-Id: Ie764ceb66dd43b951da015870e3e652ccfc651b5
    Ping-Bug: 9933
    Reviewed-on: https://code.wireshark.org/review/13347
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 24495a1b82e1c9899ee576851ad2fb33201c32ed)
    Reviewed-on: https://code.wireshark.org/review/13349
    

Actions performed:

    from  ca85d10   Fix the comment not to mention the group policy I-D.
    adds  f68b92b   Use the "no FCS" version of the Ethernet dissector.


Summary of changes:
 epan/dissectors/packet-trill.c |   11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)