Wireshark-commits: [Wireshark-commits] master-2.0 f207280: IEEE802.11: fix EAPOL key frame detectio
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 16 Jan 2016 17:51:09 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f20728045765c6558e51ee325d46b763d5df170b
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

f207280 by Alexander Wetzel (alexander.wetzel@xxxxxx):

    IEEE802.11: fix EAPOL key frame detection
    
    Use eapol key data length to differentiate between #2 and #4.
    This should work around ieee802.11 client implementation errors.
    
    Windows is setting the Secure Bit on #2 when rekeying and Bug 11994
    has a sample capture with the Nonce set in #4 and are so both
    violating the spec.
    
    Bug: 11994
    Change-Id: Ia9e9c68d08dae042cfa7fd9517892db211b0a00f
    Reviewed-on: https://code.wireshark.org/review/13299
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    (cherry picked from commit 6425ba961dc481439c2856052e6e831fa5dc426f)
    Reviewed-on: https://code.wireshark.org/review/13332
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  bab619f   Keep comments from stealing hierarchy statistics.
    adds  f207280   IEEE802.11: fix EAPOL key frame detection


Summary of changes:
 epan/crypt/airpdcap.c              |    6 ++----
 epan/crypt/airpdcap_user.h         |   11 -----------
 epan/dissectors/packet-ieee80211.c |   20 +++++++++-----------
 3 files changed, 11 insertions(+), 26 deletions(-)