Wireshark · Wireshark-commits: [Wireshark-commits] master 6ef2b48: uaudp: fix buffer overrun while reading pref

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6ef2b48dbe280bdc2c2e8559556a426a9ae44b0d
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

6ef2b48 by Peter Wu (peter@xxxxxxxxxxxxx):

    uaudp: fix buffer overrun while reading pref
    
    Drop the custom str_to_addr_ip, it overruns the buffer with at most 3
    bytes when an empty string is passed. Remove sizeof(guint8) while at it,
    the C standard requires this to be 1.
    
    Avoid overwriting uaudp.system_ip to avoid an invalid free of the
    preference.
    
    Change-Id: I39cb0a35364f2ecd32b780fcb7c0253bd866f329
    Reviewed-on: https://code.wireshark.org/review/13145
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  cefd1d4   ssl: avoid duplicate PDU dissections
    adds  6ef2b48   uaudp: fix buffer overrun while reading pref


Summary of changes:
 epan/dissectors/packet-uaudp.c |   56 ++++++++++++----------------------------
 1 file changed, 17 insertions(+), 39 deletions(-)