Wireshark · Wireshark-commits: [Wireshark-commits] master 863ef19: RTPS: Call dissector for user data using Type Name

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=863ef1909adfd3e34f1b80922ef72b05fd5207fa
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

863ef19 by Juanjo Martin (juanjo@xxxxxxx):

    RTPS: Call dissector for user data using Type Name
    
    With this dissector, anyone can write a plugin to dissect their
    data type and RTPS will call it if the dissector is registered using
    the Type Name (what is the common thing to do).
    
    Also, added a fix in dissect_APP_ACK so now the APP_ACK messages
    are properly dissected. It had a couple of wrong offsets and was
    calling dissect_serialized_data instead of directly adding the
    serialized data (dissecting an encapsulation that is not there).
    
    Bug: 11917
    Change-Id: Ie1c6880d60e3537a1cbae4840cc6ff6e1a62ca0e
    Reviewed-on: https://code.wireshark.org/review/12824
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  9a19c14   Expand a comment.
    adds  863ef19   RTPS: Call dissector for user data using Type Name


Summary of changes:
 epan/dissectors/packet-rtps.c |   79 ++++++++++++++++++++++++++++-------------
 1 file changed, 54 insertions(+), 25 deletions(-)