Wireshark · Wireshark-commits: [Wireshark-commits] master bf0f5a9: Use result of register_dissector

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bf0f5a982bc0666b6fa8d70c8d64cb1f07ab12ad
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

bf0f5a9 by Peter Wu (peter@xxxxxxxxxxxxx):

    Use result of register_dissector
    
    Assign result of `register_dissector(..., func, proto)` to FOO_handle
    and remove `FOO_handle = create_dissector_handle(func, proto)`.
    
    Found by looking for files named packet-FOO.c having the above
    create_dissector_handle pattern. Some files (with different dissect
    routines for the two functions) remain unchanged.
    
    Change-Id: Ifbed8202c6dbc63a1dae9acc03313980ffbbbb90
    Reviewed-on: https://code.wireshark.org/review/13247
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  4f4769a   Move structure definition outside another structure definition.
    adds  bf0f5a9   Use result of register_dissector


Summary of changes:
 epan/dissectors/packet-bgp.c           |    7 +++----
 epan/dissectors/packet-bpq.c           |    6 ++----
 epan/dissectors/packet-cbor.c          |    7 +++----
 epan/dissectors/packet-cfdp.c          |    8 +++-----
 epan/dissectors/packet-cipmotion.c     |   10 ++++------
 epan/dissectors/packet-cipsafety.c     |    9 +++++----
 epan/dissectors/packet-clnp.c          |    3 +--
 epan/dissectors/packet-cp2179.c        |    6 +++---
 epan/dissectors/packet-dcm.c           |    4 +---
 epan/dissectors/packet-dhcpv6.c        |    7 ++++---
 epan/dissectors/packet-ehdlc.c         |    7 +++----
 epan/dissectors/packet-gvcp.c          |   17 ++++++-----------
 epan/dissectors/packet-gvsp.c          |    3 +--
 epan/dissectors/packet-iscsi.c         |    3 +--
 epan/dissectors/packet-isup.c          |    6 +++---
 epan/dissectors/packet-ixveriwave.c    |    1 -
 epan/dissectors/packet-mgcp.c          |    3 +--
 epan/dissectors/packet-mip6.c          |    8 +++-----
 epan/dissectors/packet-mongo.c         |    7 +++----
 epan/dissectors/packet-mysql.c         |    3 +--
 epan/dissectors/packet-nasdaq-itch.c   |    7 +++----
 epan/dissectors/packet-nwp.c           |    6 +++---
 epan/dissectors/packet-openflow.c      |    3 +--
 epan/dissectors/packet-peekremote.c    |    6 ++----
 epan/dissectors/packet-redback.c       |    4 +---
 epan/dissectors/packet-rgmp.c          |    7 +++----
 epan/dissectors/packet-rsl.c           |    6 ++----
 epan/dissectors/packet-rtacser.c       |   12 ++----------
 epan/dissectors/packet-selfm.c         |    6 +++---
 epan/dissectors/packet-stanag4607.c    |    8 +++-----
 epan/dissectors/packet-tipc.c          |    3 +--
 epan/dissectors/packet-xip.c           |    9 ++++-----
 plugins/wimaxasncp/packet-wimaxasncp.c |   13 ++-----------
 33 files changed, 81 insertions(+), 134 deletions(-)