Wireshark-commits: [Wireshark-commits] master d286243: Dissect the MC and AAL2 headers as 32-bit wo
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 13 Jan 2016 05:22:23 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d286243d0d7f83e39b5ac3aec4524eea3294147f
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

d286243 by Guy Harris (guy@xxxxxxxxxxxx):

    Dissect the MC and AAL2 headers as 32-bit words.
    
    That's how they're extracted in the libwiretap module, and that's how
    they're shown in the ERF spec.
    
    This gets rid of some compiler warnings about type-punning.
    
    Merge some reserved bit fields to match what's in the ERF spec.
    Renumber others.
    
    Process the AAL2 and MC headers differently; yes, they're both
    big-endian 32-bit values, but that makes the code a bit clearer, and,
    heck, the optimizer may well combine the two sequences of code.
    
    Change-Id: Ief7f976e77e8f2fba1685ad5a50ee677a8070ae7
    Reviewed-on: https://code.wireshark.org/review/13251
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  b7dc773   Assorted cleanups.
    adds  d286243   Dissect the MC and AAL2 headers as 32-bit words.


Summary of changes:
 epan/dissectors/packet-erf.c |  530 +++++++++++++++++++-----------------------
 wiretap/erf.c                |   16 +-
 wiretap/erf.h                |    4 +
 wiretap/wtap.h               |    1 +
 4 files changed, 263 insertions(+), 288 deletions(-)