Wireshark-commits: [Wireshark-commits] master 308b653: Qt: Queue up redissection.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 8 Jan 2016 21:45:02 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=308b653da2afd05f62b944dda965d45650b23cf4
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

308b653 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Queue up redissection.
    
    Make the WiresharkApplication::packetDissectionChanged →
    MainWindow::redissectPackets connection queued rather than direct.
    redissectPackets eventually calls update_progress_dlg, which processes
    UI events.
    
    This should keep the profile dialog from destroying itself prematurely
    in a nested event loop when the user hits "OK".
    
    Bug: 11979
    Change-Id: I7276e08c1911708c3aca5ff05ab6a40bfc336add
    Reviewed-on: https://code.wireshark.org/review/13134
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  cd70269   Fix a lot of typos and misspellings
    adds  308b653   Qt: Queue up redissection.


Summary of changes:
 ui/qt/main_window.cpp |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)