Wireshark · Wireshark-commits: [Wireshark-commits] master 0c7eb4a: [dcom] don't THROW() an exception from a dissector

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0c7eb4a4f4d351aa99adefb798eec90293aac131
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

0c7eb4a by Martin Kaiser (wireshark@xxxxxxxxx):

    [dcom] don't THROW() an exception from a dissector
    
    try to clean up the use of signed vs unsigned data types
    in dissect_dcom_BSTR without affecting any other function:
    
    offsets are gint
    if we have to add a guint32 to an offset, do a range check before adding
    if we see an overflow, return the number of bytes consumed up to that point
    
    Change-Id: Ib06c19fee8e3477e07b190ca26743891a5b24c3d
    Reviewed-on: https://code.wireshark.org/review/13082
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  ccdb8be   Clean up indentation.
    adds  0c7eb4a   [dcom] don't THROW() an exception from a dissector


Summary of changes:
 epan/dissectors/packet-dcom.c |   25 ++++++++++++++-----------
 1 file changed, 14 insertions(+), 11 deletions(-)