Wireshark-commits: [Wireshark-commits] master b400b8c: pcap_list_datalinks() failing is an error.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 7 Jan 2016 06:07:52 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b400b8c50eae4ccae33180035f0942a163a18a5e
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b400b8c by Guy Harris (guy@xxxxxxxxxxxx):

    pcap_list_datalinks() failing is an error.
    
    Return an error string if that happens.
    
    If it doesn't fail, it will return a value >= 1; it will never return 0,
    so don't check for that.
    
    Change-Id: I6d7ee2683c1ceae73e9d9d61c0a6e6d30b2c4400
    Reviewed-on: https://code.wireshark.org/review/13100
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  51a99ca   Clean up #ifdeffed code.
    adds  b400b8c   pcap_list_datalinks() failing is an error.


Summary of changes:
 caputils/capture-pcap-util.c |   25 +++++++++++++++----------
 1 file changed, 15 insertions(+), 10 deletions(-)