Wireshark · Wireshark-commits: [Wireshark-commits] master 57acc22: KISS the Follow TCP functionality.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=57acc227f08fd05fb20b577568780deff77f972f
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

57acc22 by Michael Mann (mmann78@xxxxxxxxxxxx):

    KISS the Follow TCP functionality.
    
    [KISS - Keep It Simple, Stupid]
    Convert the Follow TCP functionality to use a tap from the TCP dissector that passes the tvb of the payload.  This makes things A LOT simpler, but relies on the TCP dissector to make all decisions.
    The "tap" logic passes tvb data
    1. Before calls to process_tcp_payload
    2. Before hf_tcp_segment_data fields (that aren't retransmissions or otherwise handled)
    
    Follow up patches will be necessary to clean up all of the supporting "follow" functionality that is now useless.
    
    Bug: 6925
    Bug: 9780
    Change-Id: I4e7f5d453519be839de39a109bafa899b9987139
    Reviewed-on: https://code.wireshark.org/review/13038
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  aede5c0   [OSC] fix and tidy up MIDI in OSC dissector.
    adds  57acc22   KISS the Follow TCP functionality.


Summary of changes:
 debian/libwireshark0.symbols   |    3 +-
 epan/dissectors/packet-tcp.c   |   55 ++++--
 epan/follow.c                  |  366 ++++--------------------------------
 epan/follow.h                  |    7 +-
 ui/cli/tap-follow.c            |   15 +-
 ui/gtk/follow_http.c           |    2 +
 ui/gtk/follow_ssl.c            |    2 +-
 ui/gtk/follow_tcp.c            |  322 +++++++++++---------------------
 ui/gtk/follow_udp.c            |    2 +
 ui/qt/follow_stream_dialog.cpp |  405 +++++++++-------------------------------
 ui/qt/follow_stream_dialog.h   |    4 +-
 11 files changed, 279 insertions(+), 904 deletions(-)