Wireshark-commits: [Wireshark-commits] master 4762828: Use TCP FIN bit to help determine desegmenta
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 6 Jan 2016 02:54:21 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=47628281331a57c99247be4c07d6ef93801bed0f
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

4762828 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Use TCP FIN bit to help determine desegmentation in HTTP dissector.
    
    Have the TCP dissector pass FIN bit to subdissectors (HTTP only one currently using it) so subdissector can use information to determine that no more segments are coming.
    
    Bug: 9848
    Change-Id: I4aebb5141f41d99598e4776bf25e74101016f5d1
    Reviewed-on: https://code.wireshark.org/review/12984
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  1b222b8   Remove unnecessary #ifdef and includes.
    adds  4762828   Use TCP FIN bit to help determine desegmentation in HTTP dissector.


Summary of changes:
 epan/dissectors/packet-http.c |   15 ++++++++-------
 epan/dissectors/packet-tcp.c  |    4 +++-
 epan/dissectors/packet-tcp.h  |    1 +
 3 files changed, 12 insertions(+), 8 deletions(-)