Wireshark-commits: [Wireshark-commits] master 32f9f92: Rename ipv4_addr and ipv6_addr to indicate t
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 4 Jan 2016 00:03:44 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=32f9f92487f797bcaef6d3cbf92b7fb802a6079e
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

32f9f92 by Guy Harris (guy@xxxxxxxxxxxx):

    Rename ipv4_addr and ipv6_addr to indicate their full contents.
    
    They're not just addresses, they also include a mask length for IPv4 and
    a prefix length for IPv6.  Rename them appropriately.
    
    Rename the old ipv4_addr_and_mask() and ipv6_addr_and_mask() to reflect
    that 1) they fetch data from a tvbuff and 2) *don't* fetch the mask
    length or prefix length, those lengths are passed as arguments to
    indicate how many bytes worth of address to fetch.
    
    Change-Id: I4cad5a186ad7bfcb60022a91dbe8bc8479e6471f
    Reviewed-on: https://code.wireshark.org/review/13035
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  fa7cf87   Rename ipv6-utils.h to ipv6.h.
    adds  32f9f92   Rename ipv4_addr and ipv6_addr to indicate their full contents.


Summary of changes:
 epan/addr_and_mask.c              |    7 ++++---
 epan/addr_and_mask.h              |    6 +++---
 epan/dissectors/packet-bgp.c      |   24 +++++++++++-----------
 epan/dissectors/packet-eigrp.c    |    4 ++--
 epan/dissectors/packet-isis-lsp.c |    4 ++--
 epan/ftypes/ftype-ipv4.c          |   24 +++++++++++-----------
 epan/ftypes/ftype-ipv6.c          |    8 ++++----
 epan/ftypes/ftypes.h              |   34 +++++++++++++++----------------
 epan/ipv4.c                       |   32 ++++++++++++++---------------
 epan/ipv4.h                       |   38 ++++++++++++++++++-----------------
 epan/ipv6.h                       |    2 +-
 epan/proto.c                      |   40 ++++++++++++++++++-------------------
 ui/gtk/packet_win.c               |    2 +-
 ui/gtk/rtp_analysis.c             |   10 +++++-----
 ui/qt/rtp_analysis_dialog.cpp     |   10 +++++-----
 15 files changed, 124 insertions(+), 121 deletions(-)