Wireshark-commits: [Wireshark-commits] master-2.0 af65213: Clean up error checking and handling.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 3 Jan 2016 03:31:15 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=af65213f32527509d2f1152aded3b0197dabaa8c
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

af65213 by Guy Harris (guy@xxxxxxxxxxxx):

    Clean up error checking and handling.
    
    The TLV length includes the T and the V, so it must be at least 4; fail
    if it's not.
    
    If the IPv4 or IPv6 prefix length isn't valid, don't bother trying to
    parse the rest of the addresses, just give up.
    
    Don't bother returning offset values that aren't used.
    
    Rename some routines to indicate that they process more than one item.
    
    Add some comments while we're at it.
    
    Change-Id: I6825216f0e7218e230d8d60d958b3c2453a3bb62
    Reviewed-on: https://code.wireshark.org/review/13016
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit d4f7f21b51532c1a45a43764fa92cd55e17931de)
    Reviewed-on: https://code.wireshark.org/review/13017
    

Actions performed:

    from  ce3661c   EIGRP: field eigrp.ipv4.destination does not show the correct destination
    adds  af65213   Clean up error checking and handling.


Summary of changes:
 epan/dissectors/packet-eigrp.c |  126 ++++++++++++++++++----------------------
 1 file changed, 55 insertions(+), 71 deletions(-)