Wireshark-commits: [Wireshark-commits] master cc4e827: Get rid of an unnecessary level of indirecti
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 2 Jan 2016 01:09:53 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cc4e827a3fa90031bec6c654fc1b5ac7e56226d1
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

cc4e827 by Guy Harris (guy@xxxxxxxxxxxx):

    Get rid of an unnecessary level of indirection.
    
    Instead of an array of pointers to preference values, have an array
    of preference values.
    
    Clean up some white space while we're at it.
    
    Change-Id: Iaa2cf6bcc2a271a5c2645ddbb2dbddba311b413d
    Reviewed-on: https://code.wireshark.org/review/13002
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  86339e9   Use #defines for the values for the facility_encoding preference.
    adds  cc4e827   Get rid of an unnecessary level of indirection.


Summary of changes:
 asn1/nbap/packet-nbap-template.c |   52 ++++++++++++++++-----------------
 epan/dissectors/packet-nbap.c    |   60 ++++++++++++++++++--------------------
 2 files changed, 54 insertions(+), 58 deletions(-)