Wireshark-commits: [Wireshark-commits] master f15ab3e: DNP3: dissector cleanup
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 1 Jan 2016 20:14:56 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f15ab3e6c790e2645885e959f8ae1352d4a6130b
Submitter: Graham Bloice (graham.bloice@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

f15ab3e by Graham Bloice (graham.bloice@xxxxxxxxxxxxx):

    DNP3: dissector cleanup
    
    Cleaned up handling of the qualifier field.  Sub-parts are now
    identified as the prefix and range rather than index and code.
    
    This has changed the field names;
      dnp3.al.objq.index -> dnp3.al.objq.prefix
      dnp3.al.objq.code  -> dnp3.al.objq.range
    
    and the associated packet tree details text strings.
    
    Change-Id: I42d51b71233303eaf8b37982dd15b5090918630b
    Reviewed-on: https://code.wireshark.org/review/12998
    Petri-Dish: Graham Bloice <graham.bloice@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Graham Bloice <graham.bloice@xxxxxxxxxxxxx>
    

Actions performed:

    from  376b156   Only use nibble logic to determine MPLS payload
    adds  f15ab3e   DNP3: dissector cleanup


Summary of changes:
 epan/dissectors/packet-dnp.c |  256 +++++++++++++++++++++---------------------
 1 file changed, 126 insertions(+), 130 deletions(-)