Wireshark · Wireshark-commits: [Wireshark-commits] master b344107: Make color filters part of dissection

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b344107d757466e0768a3ef8927852479e926cf6
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b344107 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Make color filters part of dissection
    
    Color filters can be seen as a function that takes a tree and display
    filters as input and a (possibly empty) coloring rule as output.
    This coloring rule is then added to the frame tree and used by the GUI
    for coloring the packets list.
    
    From an architectural POV, "coloring" is part of the UI component, but
    since it influences the tree, it is something for the dissection
    component.
    
    Bug: 5703
    Bug: 6099
    Change-Id: I73d132ec1dca7262bcb1b55c8481ca564c6161d1
    Reviewed-on: https://code.wireshark.org/review/12507
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  b1281c8   GTK: add a missing cast in dissector_tables_dlg.c
    adds  b344107   Make color filters part of dissection


Summary of changes:
 epan/color_filters.c           |    7 ++++---
 epan/dissectors/file-file.c    |   29 +++++++++++++++++------------
 epan/dissectors/packet-frame.c |   26 +++++++++++++++-----------
 epan/packet.c                  |   15 +++++++++------
 epan/packet.h                  |   10 ++++++++++
 ui/gtk/packet_list_store.c     |    3 ---
 ui/qt/packet_list_record.cpp   |    3 ---
 7 files changed, 55 insertions(+), 38 deletions(-)