Wireshark-commits: [Wireshark-commits] master aaa5ed4: No, you don't have to allocate colors.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 1 Jan 2016 01:13:06 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=aaa5ed4ad73ca537e3cd1a45ce7b8bb10371b822
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

aaa5ed4 by Guy Harris (guy@xxxxxxxxxxxx):

    No, you don't have to allocate colors.
    
    That code's been unused since at least 1.12, so apparently it's not
    needed.  To the extent that it needs to be allocated at all - which is
    the case only if a colormap is being used - it's apparently all done
    under the covers.
    
    Change-Id: Ib25bfba618b0af4a60ce991a974de1e3f2f89158
    Reviewed-on: https://code.wireshark.org/review/12981
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  44eda0c   CPack: WiX updates.
    adds  aaa5ed4   No, you don't have to allocate colors.


Summary of changes:
 ui/gtk/color_utils.c  |   59 +------------------------------------------------
 ui/gtk/color_utils.h  |   12 ----------
 ui/gtk/main.c         |    3 ---
 ui/gtk/main_welcome.c |   20 -----------------
 ui/gtk/packet_panes.c |   11 ---------
 5 files changed, 1 insertion(+), 104 deletions(-)