Wireshark-commits: [Wireshark-commits] master 146c4b7: uat: Fix warnings [-Wcast-qual]
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 31 Dec 2015 22:56:44 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=146c4b701696cb54e9e5ad4668e3ad88743c546e
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

146c4b7 by João Valverde (joao.valverde@xxxxxxxxxxxxxxxxxx):

    uat: Fix warnings [-Wcast-qual]
    
    uat_fld_tostr_cb_t callback *out_ptr argument is g_mallocated and
    is to be freed by the caller so drop constness requirement to fix
    the corresponding g_free warnings.
    
    Change-Id: I1be25fa3e2f54fb32058ac0b5c1631b193b07701
    Reviewed-on: https://code.wireshark.org/review/12943
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  c14df7f   Don't allocate something until we know we need it.
    adds  146c4b7   uat: Fix warnings [-Wcast-qual]


Summary of changes:
 epan/dissectors/packet-lbm.h |    4 ++--
 epan/uat.c                   |    4 ++--
 epan/uat.h                   |   22 +++++++++++-----------
 ui/gtk/uat_gui.c             |    4 ++--
 ui/qt/uat_dialog.cpp         |   10 +++++-----
 5 files changed, 22 insertions(+), 22 deletions(-)