Wireshark-commits: [Wireshark-commits] master-1.12 b2c9e5a: Define the SHA-1 digest length in wsuti
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 21 Dec 2015 09:39:13 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b2c9e5a9b1783636e8daba81999bf75344a96731
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-1.12
Repository: wireshark

Commits:

b2c9e5a by Guy Harris (guy@xxxxxxxxxxxx):

    Define the SHA-1 digest length in wsutil/sha1.h and use it.
    
    Hopefully that'll make it a little easier to make sure that we're not
    overflowing arrays.
    
    Change-Id: Id68d304cbae47bce3cd96b87cda4ba7dd6efc7af
    Reviewed-on: https://code.wireshark.org/review/12779
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  854e49e   airpdcap: ensure that buffer put on stack is big enough to hold the result of AirPDcapRsnaPwd2PskStep()
    adds  b2c9e5a   Define the SHA-1 digest length in wsutil/sha1.h and use it.


Summary of changes:
 asn1/cms/packet-cms-template.c   |    5 ++---
 asn1/snmp/packet-snmp-template.c |    8 ++++----
 epan/crypt/airpdcap.c            |   18 ++++++++----------
 epan/dissectors/packet-cms.c     |   13 ++++++-------
 epan/dissectors/packet-l2tp.c    |    9 ++++-----
 epan/dissectors/packet-sigcomp.c |    4 ++--
 epan/dissectors/packet-snmp.c    |    8 ++++----
 wsutil/sha1.c                    |   16 ++++++++--------
 wsutil/sha1.h                    |   11 ++++++++---
 9 files changed, 46 insertions(+), 46 deletions(-)