Wireshark-commits: [Wireshark-commits] master 3d0f9a4: No need to free the value of a string prefer
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3d0f9a4397125af15f40ab29e3fd1ad0ae2aae1a
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
3d0f9a4 by Guy Harris (guy@xxxxxxxxxxxx):
No need to free the value of a string preference in the garbage collector.
The preference has already been deregistered at that point, so the value
of the preference has been freed and the pointer to it has been set to
null, so it's already been freed and its pointer no longer points to it
and the free from Lua will do nothing.
Change-Id: I11bf74932303151483cd3699659f67d64b466759
Reviewed-on: https://code.wireshark.org/review/12606
Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
Actions performed:
from 41310fc recent.c: fix declaration of ‘value_string’ shadows a global declaration
adds 3d0f9a4 No need to free the value of a string preference in the garbage collector.
Summary of changes:
epan/wslua/wslua_pref.c | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)