Wireshark-commits: [Wireshark-commits] master 4b6d9a7: ui: Read and write correct recent timestamp
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 13 Dec 2015 20:21:34 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4b6d9a7927c612014518c6bbda82611213ac4132
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

4b6d9a7 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    ui: Read and write correct recent timestamp format
    
    Rewrite to use value_string to ensure correct value strings used,
    to add backward compatibility and to avoid global-buffer-overflow
    in possible future inconsistencies.
    
    This bug was introduced in 2a088c1d when adding new timestamp formats.
    
    Change-Id: I1bf4ac8427db92bfb56b4e5b90809fe08eebed20
    Reviewed-on: https://code.wireshark.org/review/12584
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  e73fc7e   Qt: Removed applyRecentColumnWidths from recentFilesRead
    adds  4b6d9a7   ui: Read and write correct recent timestamp format


Summary of changes:
 ui/recent.c |   74 ++++++++++++++++++++++++++++++++---------------------------
 1 file changed, 40 insertions(+), 34 deletions(-)