Wireshark-commits: [Wireshark-commits] master f06bbe3: Qt: validate format string before calling st
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 12 Dec 2015 23:50:05 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f06bbe37c12c7788702cc8649e3da1f18c730931
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

f06bbe3 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    Qt: validate format string before calling strftime()
    
    According to https://msdn.microsoft.com/en-us/library/fe06s4ak.aspx
    an invalid string will trigger invalid parameter handler
    
    Also check the validity of each field before activating import button
    
    Bug: 11873
    Change-Id: I9fc1c6e061a02354690871410f0e2cf2e0dd86a7
    Reviewed-on: https://code.wireshark.org/review/12537
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  5133221   Qt: Apply recent column widths when columns changed
    adds  f06bbe3   Qt: validate format string before calling strftime()


Summary of changes:
 ui/qt/import_text_dialog.cpp |   92 +++++++++++++++++++++++++++++++-----------
 ui/qt/import_text_dialog.h   |   15 ++++++-
 ui/qt/import_text_dialog.ui  |    2 +-
 3 files changed, 83 insertions(+), 26 deletions(-)