Wireshark-commits: [Wireshark-commits] master-2.0 e27455c: Qt: Don't expose ColorUtils::graph_color
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 1 Dec 2015 05:19:33 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e27455ca4c9b0c5ae1b9c811611c7f635975c34e
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

e27455c by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Don't expose ColorUtils::graph_colors_.
    
    Make graph_colors_ private and accessible via getters. Blind attempt at
    fixing bug 11833.
    
    Bug: 11833
    Change-Id: I03b7e90c686374d2d0f046f7e5fe87e43939dc82
    Reviewed-on: https://code.wireshark.org/review/12318
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 79f7edba15dc4c637c7f19c0770c2ba2721d765a)
    Reviewed-on: https://code.wireshark.org/review/12327
    

Actions performed:

    from  2baaeb0   [MP2T] Prevent divide by zero.
    adds  e27455c   Qt: Don't expose ColorUtils::graph_colors_.


Summary of changes:
 ui/qt/color_utils.h            |    6 +++++-
 ui/qt/iax2_analysis_dialog.cpp |    4 ++--
 ui/qt/io_graph_dialog.cpp      |    9 +++------
 ui/qt/io_graph_dialog.h        |    6 +++++-
 ui/qt/rtp_analysis_dialog.cpp  |    4 ++--
 ui/qt/rtp_player_dialog.cpp    |    2 +-
 6 files changed, 18 insertions(+), 13 deletions(-)