Wireshark-commits: [Wireshark-commits] master-2.0 bb206e8: Qt: Check capture filter only once when
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 29 Nov 2015 19:01:01 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bb206e8c6cc5a6d82e033d3e01e4e2202f5246bf
Submitter: Stig Bj?rlykke (stig@xxxxxxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark

Commits:

bb206e8 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    Qt: Check capture filter only once when selecting interface(s)
    
    Changed to only check capture filter once (for each active DLT) when
    changing selected interface(s).  This optimizes filter checking and
    avoids a "No interfaces selected" error when processing unselected
    interfaces before selected.
    
    Added a small optimization fetching device_name outside loop.
    
    Bug: 11671
    Change-Id: I01ed7a99a2a9ced9a86774a78bec2ba27b4bb97c
    Reviewed-on: https://code.wireshark.org/review/12268
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    (cherry picked from commit e75f74add63243fcaf620e47ae232f26a5b6dd67)
    Reviewed-on: https://code.wireshark.org/review/12292
    

Actions performed:

    from  af152e4   GSM SMS: fix reassembly of UCS2 encoded SMS
    adds  bb206e8   Qt: Check capture filter only once when selecting interface(s)


Summary of changes:
 ui/qt/interface_tree.cpp |    6 +++---
 ui/qt/interface_tree.h   |    2 +-
 ui/qt/main_welcome.cpp   |    2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)