Wireshark · Wireshark-commits: [Wireshark-commits] master 5f713f2: http: detect multiple names in Transfer-Encoding header

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5f713f27edadff9702ae486c1f6aa2790be28c97
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

5f713f2 by Peter Wu (peter@xxxxxxxxxxxxx):

    http: detect multiple names in Transfer-Encoding header
    
    Treat Transfer-Encoding: chunked specially, it is applied as final
    encoding and must be stripped first.
    
    Rename the expert info field http.chunkd_and_length (sic) to something
    more generic and add a new field for unknown Transfer-Encodings
    (implementations should normally send an error response, but we are not
    a server so try to be permissive).
    
    Also removed an unnecessary content_length check, it was covered by
    have_content_length.
    
    Tested with the weird crafted capture from bug 11801 and a crafted
    capture (netcat) which returns Content-Length: 1 and Transfer-Encoding:
    bla,chunked.
    
    Bug: 11801
    Change-Id: I978bf74e52e70782ebc5153d1017de67f323e514
    Reviewed-on: https://code.wireshark.org/review/12256
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  15edc8d   Fix bugs introduced in gcfc47c1
    adds  5f713f2   http: detect multiple names in Transfer-Encoding header


Summary of changes:
 epan/dissectors/packet-http.c |  198 ++++++++++++++++++++++++++++++-----------
 1 file changed, 145 insertions(+), 53 deletions(-)