Wireshark-commits: [Wireshark-commits] master 05121be: Qt: reload after applying parameters in UDP
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 28 Nov 2015 07:54:37 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=05121be1b4ea35257bfcd8ed38d2312b1519f370
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

05121be by Peter Wu (peter@xxxxxxxxxxxxx):

    Qt: reload after applying parameters in UDP multicast dialog
    
    Noticed this message in stderr, started investigating:
    
        QObject::connect: No such signal MulticastStatisticsDialog::updateFilter(QString&,bool) in ui/qt/multicast_statistics_dialog.cpp:247
        QObject::connect:  (sender name:   'TapParameterDialog')
        QObject::connect:  (receiver name: 'TapParameterDialog')
    
    Verified that after this patch, the "Max Burst" changes from "4/100ms"
    to "1/1ms" when modifying "Burst measurement interval (ms)" from 100 to
    1 using rtp-norm-transfer.pcap from the SampleCaptures wiki.
    
    Change-Id: I803ff9e5a542a5fd3507b086f29628fbf5602784
    Reviewed-on: https://code.wireshark.org/review/12228
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  75da696   Qt: set focus to text box when opening search frame
    adds  05121be   Qt: reload after applying parameters in UDP multicast dialog


Summary of changes:
 ui/qt/multicast_statistics_dialog.cpp |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)