Wireshark-commits: [Wireshark-commits] master d7f1243: Fix crash in UDP Multicast Streams dialog
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 27 Nov 2015 21:15:20 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d7f12436709e40d58d7fcdfbcdd08740c039e162
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

d7f1243 by Peter Wu (peter@xxxxxxxxxxxxx):

    Fix crash in UDP Multicast Streams dialog
    
    Attempting to open the UDP Multicast Streams dialog in the GTK UI
    triggers an instant crash (heap-buffer-overflow).
    
    Déjà vu. This is the same problem that plagued the RTP Streams dialog.
    This patch is based on the fix in v1.99.3rc0-33-g2c65b33
    (mcaststream_dlg_update confused GList vs. mcaststream_tapinfo_t).
    
    After fixing that, the dialog crashed shortly after setting parameters
    (heap-use-after-free). That fix is based on v1.99.10rc0-292-gb02a0ee
    (after a retap, the old items were still present in the list).
    
    Just that change was not enough as clearing the list still triggered a
    signal, possibly because of the "changed" signal (while the RTP player
    uses a selection setter function). Apply the patch based on
    v1.99.10rc0-270-g01bd832 (disable selection while clearing).
    
    Change-Id: I152bac6f954d8d1c5c20d6c7d56a196c3e20c681
    Reviewed-on: https://code.wireshark.org/review/12227
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  56625dd   Qt: remove automatic horizontal scrolling when selecting a row
    adds  d7f1243   Fix crash in UDP Multicast Streams dialog


Summary of changes:
 ui/gtk/mcast_stream_dlg.c             |   39 +++++++++++++++++++++++----------
 ui/mcast_stream.c                     |    4 ++--
 ui/mcast_stream.h                     |   12 ++++++----
 ui/qt/multicast_statistics_dialog.cpp |    8 ++-----
 ui/qt/multicast_statistics_dialog.h   |    5 +++--
 5 files changed, 42 insertions(+), 26 deletions(-)