Wireshark-commits: [Wireshark-commits] master 62b03da: Fix display of bytes as EBCDIC
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 27 Nov 2015 18:39:21 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=62b03da49a3e6c32f788da375faea2ca47fa2aa9
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

62b03da by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    Fix display of bytes as EBCDIC
    
    MSVC compiler does not support properly setting an enum being part of a bit field.
    For example the following code:
    pinfo->fd->flags.encoding = PACKET_CHAR_ENC_CHAR_EBCDIC;
    changes pinfo->fd->flags.encoding from 0x0 to 0xfffffffe instead of 0x1
    Let's put back an unsigned int definition (like it is in master-1.12 branch) and add explicit casts where required
    
    Bug: 11787
    Change-Id: Idae0140fb6c172f1b3dbf10baefc8cfb00128f4c
    Reviewed-on: https://code.wireshark.org/review/12220
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  946222c   Fix crash in Capture File Properties dialog
    adds  62b03da   Fix display of bytes as EBCDIC


Summary of changes:
 epan/frame_data.h       |    3 ++-
 epan/print.c            |    4 ++--
 ui/gtk/packet_panes.c   |    4 ++--
 ui/qt/packet_dialog.cpp |    2 +-
 ui/qt/packet_list.cpp   |    2 +-
 5 files changed, 8 insertions(+), 7 deletions(-)