Wireshark-commits: [Wireshark-commits] master-2.0 20bfc3d: autotools: do not apply CFLAGS in revers
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=20bfc3d5a9a44132e5cd1ffc3d9364dba7824574
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master-2.0
Repository: wireshark
Commits:
20bfc3d by Peter Wu (peter@xxxxxxxxxxxxx):
autotools: do not apply CFLAGS in reverse order
Fixes false "-Wvariadic-macros" because "-Wpedantic" came after
"-Wno-variadic-macros". While at it, avoid (unintentionally?) adding
-fPIE to all C++ programs (via CXXFLAGS).
Availability of flags is checked by appending a flag (in case the user
has something like CFLAGS=-Wno-error).
This removes a -fPIE check for CXXFLAGS and removes 5
-Woverlength-strings and 9 -Wvariadic-macros warnings from make with
Clang 3.7.0. configure and compile times were equal. (A diff between the
configure outputs showed no other changes.)
This reverts commit cf0d762d7304aa569ea25faf999c74bbe94f9023 and applies
a different approach.
Ping-Bug: 10791
Change-Id: Ic7b4137e2d98b06bc7625091be9bc7dd69182586
Reviewed-on: https://code.wireshark.org/review/12175
Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
(cherry picked from commit 470c745a7a0a5b930bdfb0edd8874436cb9beea0)
Reviewed-on: https://code.wireshark.org/review/12186
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from c986188 configure.ac: Fix CXXFLAGS with optimization for HP-UX
adds 20bfc3d autotools: do not apply CFLAGS in reverse order
Summary of changes:
acinclude.m4 | 42 ++++++++++++++++++++++--------------------
configure.ac | 32 +++++++++++++++++++-------------
2 files changed, 41 insertions(+), 33 deletions(-)
