Wireshark-commits: [Wireshark-commits] master 58dc5b0: SMB sidsnooping: use sid as key and name as
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 27 Nov 2015 05:34:46 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=58dc5b05b9241ec8b7942722c6fd61cb21002c68
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

58dc5b0 by Peter Wu (peter@xxxxxxxxxxxxx):

    SMB sidsnooping: use sid as key and name as value
    
    Fixes "cast from 'const char *' to 'char *' drops const qualifier
    [-Wcast-qual]", but changes the internal representation of
    sid_name_table.
    
    Change-Id: Ia853c3cf3010ea0cd1e2c975a23dd97e15be0fd6
    Reviewed-on: https://code.wireshark.org/review/12157
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Reviewed-by: Dario Lombardo <lomato@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: João Valverde <j@xxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  20a41fa   NGHTTP2: Update to 1.5.0
    adds  58dc5b0   SMB sidsnooping: use sid as key and name as value


Summary of changes:
 epan/dissectors/packet-smb-sidsnooping.c |   61 ++++--------------------------
 epan/dissectors/packet-smb-sidsnooping.h |    7 +---
 ui/cli/tap-smbsids.c                     |    8 ++--
 3 files changed, 12 insertions(+), 64 deletions(-)