Wireshark-commits: [Wireshark-commits] master 10261d1: Remove manual setting of pinfo->current_prot
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 27 Nov 2015 05:00:47 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=10261d120283cb739118fa7178b4e911ed72de14
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

10261d1 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Remove manual setting of pinfo->current_proto.
    
    Calling a protocol dissection function will properly set/restore pinfo->current_proto, so there's no need to duplicate it.
    
    Change-Id: Ic2ec0b35fa4d46a98f3410bf238056425076e4a9
    Reviewed-on: https://code.wireshark.org/review/12205
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  e2d5089   Scan pcapng change time to unsigned
    adds  10261d1   Remove manual setting of pinfo->current_proto.


Summary of changes:
 epan/dissectors/packet-arp.c             |    9 ++++----
 epan/dissectors/packet-atalk.c           |   37 ++++++++++++++++++------------
 epan/dissectors/packet-bpdu.c            |    6 -----
 epan/dissectors/packet-clip.c            |    4 +---
 epan/dissectors/packet-dcp-etsi.c        |    6 -----
 epan/dissectors/packet-ieee80211-radio.c |    1 -
 epan/dissectors/packet-nsip.c            |    2 --
 epan/dissectors/packet-osi.c             |    2 --
 epan/dissectors/packet-ositp.c           |    6 -----
 epan/dissectors/packet-pagp.c            |    2 --
 plugins/irda/packet-irda.c               |    3 ---
 11 files changed, 28 insertions(+), 50 deletions(-)