Wireshark-commits: [Wireshark-commits] master 470c745: autotools: do not apply CFLAGS in reverse or
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 26 Nov 2015 13:02:52 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=470c745a7a0a5b930bdfb0edd8874436cb9beea0
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

470c745 by Peter Wu (peter@xxxxxxxxxxxxx):

    autotools: do not apply CFLAGS in reverse order
    
    Fixes false "-Wvariadic-macros" because "-Wpedantic" came after
    "-Wno-variadic-macros". While at it, avoid (unintentionally?) adding
    -fPIE to all C++ programs (via CXXFLAGS).
    
    Availability of flags is checked by appending a flag (in case the user
    has something like CFLAGS=-Wno-error).
    
    This removes a -fPIE check for CXXFLAGS and removes 5
    -Woverlength-strings and 9 -Wvariadic-macros warnings from make with
    Clang 3.7.0. configure and compile times were equal. (A diff between the
    configure outputs showed no other changes.)
    
    This reverts commit cf0d762d7304aa569ea25faf999c74bbe94f9023 and applies
    a different approach.
    
    Ping-Bug: 10791
    Change-Id: Ic7b4137e2d98b06bc7625091be9bc7dd69182586
    Reviewed-on: https://code.wireshark.org/review/12175
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  a198f47   cmake: add asn1 target, avoid unnecessary rebuilds
    adds  470c745   autotools: do not apply CFLAGS in reverse order


Summary of changes:
 acinclude.m4 |   42 ++++++++++++++++++++++--------------------
 configure.ac |   32 +++++++++++++++++++-------------
 2 files changed, 41 insertions(+), 33 deletions(-)