Wireshark-commits: [Wireshark-commits] master 921a844: Remove use of APPEND_BOOLEAN_FLAG in favor o
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 26 Nov 2015 11:27:40 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=921a844200e32bdc4c59485c5589873540eb238c
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

921a844 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Remove use of APPEND_BOOLEAN_FLAG in favor of proto_tree_add_bitmask_with_flags.
    
    The "flags" used in proto_tree_add_bitmask-like functions can provide the same functionality of APPEND_BOOLEAN_FLAG, so it simplifies the dissector.
    
    Change-Id: I7c87cbcc9b33588bc0eea6630e03b591f9f27fc8
    Reviewed-on: https://code.wireshark.org/review/12145
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  97e627e   L2TP: Correct L2TP over IP SHA1 message digest
    adds  921a844   Remove use of APPEND_BOOLEAN_FLAG in favor of proto_tree_add_bitmask_with_flags.


Summary of changes:
 epan/dissectors/packet-bfd.c        |   52 +-------------
 epan/dissectors/packet-dec-bpdu.c   |   42 ++---------
 epan/dissectors/packet-isis-hello.c |   28 +-------
 epan/dissectors/packet-oampdu.c     |  134 ++++++-----------------------------
 4 files changed, 30 insertions(+), 226 deletions(-)