Wireshark-commits: [Wireshark-commits] master a9f5d85: NSIS: refuse to install on Windows XP or Ser
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 26 Nov 2015 08:38:31 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a9f5d8503f85704bd6facc2de3f51f5d83f4862c
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

a9f5d85 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    NSIS: refuse to install on Windows XP or Server 2003
    
    Warn the user when installing on Windows Server 2003 along with XP.
    CMake builds are not targeting them, and their support was officially
    dropped with Wireshark 1.12.
    Update our copy of GetWindowsVersion.nsh with "Alternate Script With
    Server Versions" from http://nsis.sourceforge.net/Get_Windows_version.
    
    Change-Id: I762859ea13e1ecd91757eeab360a39d1e6116144
    Reviewed-on: https://code.wireshark.org/review/11972
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    

Actions performed:

    from  1b32d50   SCTP: add another NULL dereference check
    adds  a9f5d85   NSIS: refuse to install on Windows XP or Server 2003


Summary of changes:
 packaging/nsis/GetWindowsVersion.nsh |  176 ++++++++++++++++++++++++++--------
 packaging/nsis/wireshark.nsi         |   17 ++--
 2 files changed, 146 insertions(+), 47 deletions(-)