Wireshark-commits: [Wireshark-commits] master 013bf21: [RUDP] Use proto_tree_add_bitmask instead of
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 26 Nov 2015 05:45:59 +0000 (UTC)
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=013bf21eb375cb7c27c2a8bd50a2690a344c8c3d
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

013bf21 by Michael Mann (mmann78@xxxxxxxxxxxx):

    [RUDP] Use proto_tree_add_bitmask instead of something homegrown.
    
    Also don't put calls to dissectors under an if (tree), even for the data dissector.
    
    Change-Id: Ia897d7ae7aa61c89e92949225a54f40d56c1df74
    Reviewed-on: https://code.wireshark.org/review/12155
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot <buildbot-no-reply@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  805136d   Replace tvb_get_enctohl and tvb_get_enctohs with the functions already created in tvbuff.h
    adds  013bf21   [RUDP] Use proto_tree_add_bitmask instead of something homegrown.


Summary of changes:
 epan/dissectors/packet-rudp.c |   64 +++++++++++++++++++----------------------
 1 file changed, 29 insertions(+), 35 deletions(-)